Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address configure clis #1111

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Address configure clis #1111

merged 2 commits into from
Jan 5, 2023

Conversation

qinchuanares
Copy link
Contributor

remove unnecessary -- in config CLI commands

mihirpat1
mihirpat1 reviewed Nov 18, 2022
View reviewed changes
Copy link
Contributor

@mihirpat1 mihirpat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be great if you can update the spec with the below for PM since I couldn't find it.

  1. post-fec errored frames ratio for min, avg and max
  2. evm min, avg and max
  3. cd min, avg and max
  4. Laser temperature

prgeor
prgeor previously approved these changes Dec 7, 2022
View reviewed changes
@qinchuanares
Copy link
Contributor Author

It will be great if you can update the spec with the below for PM since I couldn't find it.

  1. post-fec errored frames ratio for min, avg and max
  2. evm min, avg and max
  3. cd min, avg and max
  4. Laser temperature

I included the min/max specs for important optical and DSP specs.

@prgeor prgeor merged commit 3da9d36 into sonic-net:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihirpat1 mihirpat1 mihirpat1 approved these changes

@prgeor prgeor prgeor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qinchuanares @prgeor @mihirpat1